[DPA-1564] fund mcm pdas changeset #16436
Merged
+466
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecPablo
force-pushed
the
ecpablo/solana-mcms-signer-funding
branch
from
63f5f6d to
b6a100b
Compare
ecPablo
changed the base branch from
ecpablo/solana-ccip-transfer-ownership
to
develop
ecPablo
changed the base branch from
develop
to
ecpablo/solana-ccip-transfer-ownership
ecPablo
changed the base branch from
ecpablo/solana-ccip-transfer-ownership
to
develop
ecPablo
changed the base branch from
develop
to
ecpablo/solana-ccip-transfer-ownership
ecPablo
changed the base branch from
ecpablo/solana-ccip-transfer-ownership
to
develop
ecPablo
changed the base branch from
develop
to
ecpablo/solana-ccip-transfer-ownership
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
ecPablo
force-pushed
the
ecpablo/solana-mcms-signer-funding
branch
from
3365e8d to
9b45def
Compare
ecPablo
force-pushed
the
ecpablo/solana-mcms-signer-funding
branch
from
9b45def to
2f28357
Compare
ecPablo
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
and removed request for
a team
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Base automatically changed from
ecpablo/solana-ccip-transfer-ownership
to
develop
February 17, 2025 21:59
ecPablo
force-pushed
the
ecpablo/solana-mcms-signer-funding
branch
from
0f3bdbd to
5926d60
Compare
gustavogama-cll
previously approved these changes
Feb 17, 2025
graham-chainlink
previously approved these changes
Feb 18, 2025
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
graham-chainlink
approved these changes
Feb 18, 2025
|
jkongie
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: #16246
This pull request introduces new functionality for funding MCMS signers on the Solana blockchain. The changes include the addition of a new changeset class, corresponding test cases, and a helper function to facilitate the funding process.
New functionality for funding MCMS signers:
New Changeset Class:
deployment/common/changeset/solana/fund_mcm_pdas.go: Introduced theFundMCMSignersChangesetclass, which includes methods for verifying preconditions and applying the funding changeset. This class ensures that the deployer has sufficient funds and that the MCMS contracts are deployed before proceeding with the funding.Test Cases:
deployment/common/changeset/solana/fund_mcm_pdas_test.go: Added comprehensive test cases for theFundMCMSignersChangesetclass, covering various scenarios such as valid preconditions, insufficient deployer balance, and missing MCMS contracts.Helper Function:
deployment/common/changeset/solana/helpers.go: Added theFundFromDeployerKeyfunction to handle the transfer of SOL from the deployer to specified accounts, ensuring the transaction is confirmed.